Skip to content

Conversation

@ursfassler
Copy link
Contributor

Summary

List production code header files in CMakeLists.

Details

Motivation and Context

I work with QtCreator. That only shows the files listed in CMakeLists.txt, hence I don't see the header files by default. Also search does only search listed files.

There is already some code to add header files. This change simplifies that code a bit by removing some condition logic.

How Has This Been Tested?

Should not affect any code. Tested with existing automated tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to main, keeping only relevant commits.

@ursfassler ursfassler marked this pull request as ready for review December 28, 2023 10:05
@ursfassler ursfassler merged commit 01d24e8 into cucumber:main Dec 28, 2023
@ursfassler ursfassler deleted the list-headers branch December 28, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant