Skip to content

Enable compiling with clang's -Wsuggest-override #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Enable compiling with clang's -Wsuggest-override #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion include/cucumber-cpp/internal/RegistrationMacros.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
#ifndef CUKE_REGISTRATIONMACROS_HPP_
#define CUKE_REGISTRATIONMACROS_HPP_

#if __cplusplus >= 201103L
#define CUKE_OVERRIDE override
#else
#define CUKE_OVERRIDE
#endif

// ************************************************************************** //
// ************** OBJECT NAMING MACROS ************** //
// ************************************************************************** //
Expand All @@ -24,7 +30,7 @@
#define CUKE_OBJECT_(class_name, parent_class, registration_fn, args) \
class class_name : public parent_class { \
public: \
void body() { \
void body() CUKE_OVERRIDE { \
return invokeWithArgs(*this, &class_name::bodyWithArgs); \
} \
void bodyWithArgs args; \
Expand Down