Skip to content

Conversation

@dmeehan1968
Copy link

Summary

Boost 1.7x introduced changes to log_build_info method in the reporter class, which broke Cucumber-cpp.

Details

Add the missing bool parameter to the log_build_info method

Motivation and Context

To keep track with Boost releases.

How Has This Been Tested?

This problem caused Cucumber-cpp to fail to build when configured with CUKE_ENABLE_BOOST_TEST=on.

  • make --build build --target install
  • Tested with local project

Tested with make --build against Boost 1.74

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
    *NB: The README could be updated to say which is the latest Boost version that is tested as compatible
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to master, keeping only relevant commits.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.47% when pulling 28a2245 on dmeehan1968:fix-238-boost-1.7x-compat into dd424c1 on cucumber:master.

@dmeehan1968 dmeehan1968 changed the title Switch to Boost from GTest, add Sensor (fix #238) Fix boost 1.7x compatibility (fix #238) Oct 28, 2020
@dmeehan1968
Copy link
Author

Duplicate of #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants