Skip to content

Conversation

@LukasWoodtli
Copy link
Contributor

@LukasWoodtli LukasWoodtli commented Dec 7, 2019

Summary

Add the possibility to build with sanitizer support (address, thread, undefined).

Motivation and Context

The sanitizers are usefull for finding leaks, race conditions or undefined behaviour.

How Has This Been Tested?

Tested locally. They can be added to travis/appveyor as soon as all found bugs are fixed.

Types of changes

  • New feature (non-breaking change which adds functionality).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to master, keeping only relevant commits.

The sanitizers 'address', 'thread', and 'undefined behaviour' can
be activated.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.47% when pulling c0f7dc7 on LukasWoodtli:Sanitizers into dd424c1 on cucumber:master.

Copy link
Contributor

@jermus67 jermus67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @LukasWoodtli ,

I hope you are still monitoring this space and willing to pick up a request on this PR:

Could you remove the fix for the BoostDriver.cpp from this commit? Or merge main into this one (retaining the BoostDriver.cpp as it is, in main it now supports Boost 1.7x+)?

In the current state this PR cannot be merged (and sanitizers are indeed a good addition to the project, I think).

Kind regards,
Jeroen Kouwer

@LukasWoodtli
Copy link
Contributor Author

I‘ll have a look at this as soon as possible.

@LukasWoodtli
Copy link
Contributor Author

See #247 for new Pr replacing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants