Skip to content

fix OSX build failing on warning #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
konserw wants to merge 6 commits into from
Closed

fix OSX build failing on warning #184

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d4e7b76
fix OSX build by removing -werror
konserw Feb 14, 2018
6ed2070
Revert "fix OSX build by removing -werror"
konserw Feb 14, 2018
f06c662
fix warning instead of disabling -werror
konserw Feb 14, 2018
1a211bd
disable unused result warning localy
konserw Feb 14, 2018
c5ad7e2
fix for gcc
konserw Feb 14, 2018
879a13a
fix clang-format
konserw Feb 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions examples/CalcQt/features/step_definitions/CalculatorQtSteps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,19 @@ GIVEN("^I just turned on the calculator$") {
cucumber::ScenarioScope<CalculatorCtx> ctx;
ctx->calculator.move(0, 0);
ctx->calculator.show();
#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunused-result"
#endif
#if QT_VERSION >= 0x050000
QTest::qWaitForWindowExposed(&ctx->calculator);
#else
QTest::qWaitForWindowShown(&ctx->calculator);
#endif
#ifdef __clang__
#pragma clang diagnostic pop
#endif

QTest::qWait(millisecondsToWait());
}

Expand Down