Skip to content

Get rid of clang warning - fix for issue 119 #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
konserw wants to merge 2 commits into from
Closed

Get rid of clang warning - fix for issue 119 #138

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf39ee6
get rid of clang warning
konserw Mar 23, 2017
abfcffc
remove EXPECT_TYPE
konserw Mar 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions tests/integration/WireProtocolTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ class MockCukeEngine : public CukeEngine {
EXPECT_THAT(typeid(classname).name(), StrEq(typeid(expression).name()))

@paoloambrosio paoloambrosio Mar 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think EXPECT_TYPE was only needed for EXPECT_PTRTYPE. Guess we can remove it now.


#define EXPECT_PTRTYPE(classname, expression) \
EXPECT_TYPE(classname, *expression)


EXPECT_NE(dynamic_cast<const classname*>(expression), (void*)NULL)

class WireMessageCodecTest : public Test {
public:
Expand Down