Skip to content

Commit

Permalink
fix flaky QtTestDriver test
Browse files Browse the repository at this point in the history
The test output contained timing information, leading to a flaky test.
Fixed by using the TAP output, that doesn't contain timing information.
  • Loading branch information
ursfassler committed Apr 29, 2024
1 parent 7583400 commit 35e31c8
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions src/drivers/QtTestDriver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,10 @@ const InvokeResult QtTestStep::invokeStepBody() {
}
file.close();

QtTestObject testObject(this);
int returnValue = QTest::qExec(
&testObject,
QStringList() << "test"
<< "-o" << file.fileName()
);
QtTestObject testObject{this};
const QStringList args{"test", "-o", file.fileName() + ",tap"};
int returnValue = QTest::qExec(&testObject, args);

if (returnValue == 0) {
return InvokeResult::success();
} else {
Expand Down

0 comments on commit 35e31c8

Please sign in to comment.