Skip to content
This repository has been archived by the owner on Apr 26, 2021. It is now read-only.

Feature: Better Logging Architecture #625

Open
KillerInstinct opened this issue Aug 20, 2015 · 4 comments
Open

Feature: Better Logging Architecture #625

KillerInstinct opened this issue Aug 20, 2015 · 4 comments
Labels

Comments

@KillerInstinct
Copy link
Contributor

KillerInstinct commented Aug 20, 2015

There are multiple enhancements that could be done to the current logging architecture.

@jbremer
Copy link
Member

jbremer commented Aug 20, 2015

Agreed on most points. @rep already proposed the task aware logging a while ago but we haven't put it to production yet.
In addition to the points listed here I'd also like to see a per-task error.log which contains a dump of all exceptions that happened for this particular task. Naturally each task should have no exceptions at all, but it has happened various times where incorrect usage of 3rd party libraries caused exceptions, e.g., dpkt, pefile, volatility, etc.

@jbremer
Copy link
Member

jbremer commented Aug 20, 2015

Btw, in the case of rolling logs, we do have to make sure that logs are not magically deleted. E.g., I still may want to see the logs of an analysis half a million analyses later ;)

@KillerInstinct
Copy link
Contributor Author

Stumbled back across then when I was checking Issues I was involved in. I ended up coding the third point because an upstart job fails to account for when you want to reprocess and analysis, you're still only left with logging to STDOUT. This solves that.

Relevant commits:
spender-sandbox/cuckoo-modified@e22b9ad
spender-sandbox/cuckoo-modified@00f176c

Feel free to use/improve.

@jbremer
Copy link
Member

jbremer commented Sep 4, 2016

Having forgotten about this issue, some of the suggestions have been implemented by now.
In particular: more task ID logging, per-task logging, process.py logging (in #863), and the task aware logging.
I guess the rest have yet to be done :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@botherder @jbremer @KillerInstinct and others