feat(tesseract): Switch dimensions and case measures #9951
Merged
+8,862
−3,964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9951 +/- ##
=======================================
Coverage 84.62% 84.63%
=======================================
Files 253 253
Lines 90049 90049
=======================================
+ Hits 76204 76212 +8
+ Misses 13845 13837 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
waralexrom
force-pushed
the
tesseract-calc-groups
branch
from
731c1d4 to
b5572bd
Compare
3 tasks
KSDaemon
reviewed
Sep 17, 2025
packages/cubejs-schema-compiler/src/compiler/transpilers/CubePropContextTranspiler.ts
Outdated
Show resolved
Hide resolved
| @@ -877,7 +911,7 @@ const viewSchema = inherit(baseSchema, { | |||
| meta: Joi.any(), | |||
| }) | |||
| ])) | |||
| ]).required(), | |||
| ]), | |||
There was a problem hiding this comment.
Are you sure that having empty cubes (I mean without any includes) in view is ok?
packages/cubejs-schema-compiler/test/integration/postgres/calc-groups.test.ts
Outdated
Show resolved
Hide resolved
| console.log(JSON.stringify(res)); | ||
|
|
||
| expect(res).toEqual( | ||
| expectedResult | ||
| ); | ||
| return sqlAndParams; |
There was a problem hiding this comment.
To check final sql like expect(sqlAndParams[0]).not.toMatch(/CROSS.+JOIN/);
rust/cubesqlplanner/cubesqlplanner/src/physical_plan_builder/processors/full_key_aggregate.rs
Outdated
Show resolved
Hide resolved
rust/cubesqlplanner/cubesqlplanner/src/physical_plan_builder/processors/keys_sub_query.rs
Outdated
Show resolved
Hide resolved
waralexrom
force-pushed
the
tesseract-calc-groups
branch
from
bf21e66 to
9f7b54e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List