Skip to content

fix(schema-compiler): Use join paths from pre-aggregation declaration instead of building join tree from scratch #9471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 22, 2025

fix(schema-compiler): Handle pre-aggregations matching in presence of…

2bb6df8
Select commit
Loading
Failed to load commit list.
Merged

fix(schema-compiler): Use join paths from pre-aggregation declaration instead of building join tree from scratch #9471

fix(schema-compiler): Handle pre-aggregations matching in presence of…
2bb6df8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Apr 22, 2025 in 1s

66.66% of diff hit (target 80.54%)

View this Pull Request on Codecov

66.66% of diff hit (target 80.54%)

Annotations

Check warning on line 315 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L315 

Added line #L315 was not covered by tests

Check warning on line 319 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L319 

Added line #L319 was not covered by tests

Check warning on line 1415 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L1415 

Added line #L1415 was not covered by tests

Check warning on line 2009 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L2009 

Added line #L2009 was not covered by tests

Check warning on line 2223 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L2219-L2223 

Added lines #L2219 - L2223 were not covered by tests

Check warning on line 2950 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L2950 

Added line #L2950 was not covered by tests

Check warning on line 627 in packages/cubejs-schema-compiler/src/adapter/PreAggregations.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/adapter/PreAggregations.js#L627 

Added line #L627 was not covered by tests

Check warning on line 1137 in packages/cubejs-schema-compiler/src/adapter/PreAggregations.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/adapter/PreAggregations.js#L1136-L1137 

Added lines #L1136 - L1137 were not covered by tests

Check warning on line 664 in packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts#L663-L664 

Added lines #L663 - L664 were not covered by tests

Check warning on line 757 in packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts#L757 

Added line #L757 was not covered by tests

Check warning on line 1017 in packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts#L1016-L1017 

Added lines #L1016 - L1017 were not covered by tests

Check warning on line 1024 in packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts#L1024 

Added line #L1024 was not covered by tests

Check warning on line 1026 in packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts#L1026 

Added line #L1026 was not covered by tests

Check warning on line 1029 in packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts#L1029 

Added line #L1029 was not covered by tests

Check warning on line 1034 in packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts#L1034 

Added line #L1034 was not covered by tests

Check warning on line 1036 in packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts#L1036 

Added line #L1036 was not covered by tests

Check warning on line 1038 in packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts#L1038 

Added line #L1038 was not covered by tests
View more details on Codecov