ROS2 fix: passing extra_resource_paths#21
Merged
Conversation
stibipet
added a commit
that referenced
this pull request
Nov 3, 2025
* fix: passing argument for extra_resources * ft: creating separate files for sensors macros * ft: description for default gazebo lidar * fix: generic lidar macro, fixing few bugs along the way * ft: lidar plugin but its required to launch tf for link * fix: change lidar link name so it belongs to a namespace * fix: renaming macros and adding arguments * fix: removing merging conflicts from #21 * ft: tf publisher, bug: lidar topic stopped being published * fix: bug if no camera is used, none of the sensors will be loaded * ft: publisher that dynamically generates tf based on from sdf * ft: adding rplidar, scance sweep lidar, converting sdf_to_tf to read joints instead of links * ft: adding velodyne lidar * ft: ouster, IMU is missing * fix: garmin rangefinder, do not modify its name or topic, since PX4 will not detect it * fix: sdf2tf publisher with correct base_link, adding Garmin link as ignored * ft: extending sdf2tf publisher with offset from sensor plugins * removing unsupported components * fix: move pose under <link> tag, since joint pose does not behave the same way as in URDF * minor formatting changes * add rplidar to x500, reenable lidar mount * add lidars to f450 * enable lidar sensors for f550 * enable lidar for m690 * enable lidar sensors for t650 * add an explanation to garmin link naming Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * remove camera from the default tmux session --------- Co-authored-by: stibipet <stibipet@fel.cvut.cz> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
there is currently a bug with
mrs_drone_spawnerin ROS2 when using a custom drone configuration. The custom package defined inspawner_config.yamlunderextra_resource_pathswas not being passed tomrs_drone_spawnerwithin the launch files. This PR fixes that issue.