Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Felix, first of all thank for your awesome work! ❤️
We are developing a
sentinel_sdk
in python and I had to add thesentinel_protobuf
inside mospy.Currently the
sentinel_protobuf
is maintained by @MathNodes. I saw that 2 weeks ago you accept the PR ctrl-Felix/cosmospy-protobuf#14, but the pypi release is Nov 27, 2023 (without thesentinel_protobuf
).I had to change the requirements from
cosmospy_protobuf
tosentinel_protobuf
.Now we have two options:
sentinel_mospy
cosmospy_protobuf
(that include also sentinel) and the release an update also formospy
(this PR - with the requirements.txt rollbacked tocosmospy_protobuf
)What do you think?
The PR include also aGetTx
method, out of sentinel/chain related scope.