Skip to content

Commit

Permalink
expose more arg for c api
Browse files Browse the repository at this point in the history
  • Loading branch information
lishanglin authored and VCgege committed Nov 19, 2024
1 parent 7592b71 commit d8f52b7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions db/c.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4268,10 +4268,10 @@ void rocksdb_options_set_row_cache(rocksdb_options_t* opt,
}

void rocksdb_options_add_compact_on_deletion_collector_factory(
rocksdb_options_t* opt, size_t window_size, size_t num_dels_trigger) {
rocksdb_options_t* opt, size_t window_size, size_t num_dels_trigger, double deletion_ratio) {
std::shared_ptr<ROCKSDB_NAMESPACE::TablePropertiesCollectorFactory>
compact_on_del =
NewCompactOnDeletionCollectorFactory(window_size, num_dels_trigger);
NewCompactOnDeletionCollectorFactory(window_size, num_dels_trigger, deletion_ratio);
opt->rep.table_properties_collector_factories.emplace_back(compact_on_del);
}

Expand Down
2 changes: 1 addition & 1 deletion db/c_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ int main(int argc, char** argv) {
rocksdb_compactoptions_set_exclusive_manual_compaction(coptions, 1);

rocksdb_options_add_compact_on_deletion_collector_factory(options, 10000,
10001);
10001, 0);
rocksdb_options_add_compact_on_deletion_collector_factory_del_ratio(
options, 10000, 10001, 0.0);

Expand Down
2 changes: 1 addition & 1 deletion include/rocksdb/c.h
Original file line number Diff line number Diff line change
Expand Up @@ -1750,7 +1750,7 @@ extern ROCKSDB_LIBRARY_API void rocksdb_options_set_row_cache(

extern ROCKSDB_LIBRARY_API void
rocksdb_options_add_compact_on_deletion_collector_factory(
rocksdb_options_t*, size_t window_size, size_t num_dels_trigger);
rocksdb_options_t*, size_t window_size, size_t num_dels_trigger, double deletion_ratio);
extern ROCKSDB_LIBRARY_API void
rocksdb_options_add_compact_on_deletion_collector_factory_del_ratio(
rocksdb_options_t*, size_t window_size, size_t num_dels_trigger,
Expand Down

0 comments on commit d8f52b7

Please sign in to comment.