Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set isAxiosError property on errors. #210

Merged
merged 2 commits into from
Jan 4, 2020
Merged

Set isAxiosError property on errors. #210

merged 2 commits into from
Jan 4, 2020

Conversation

gilbsgilbs
Copy link
Contributor

@gilbsgilbs gilbsgilbs force-pushed the is-axios-error-property branch from 2e9eb29 to a52ff20 Compare July 8, 2019 13:56
@donaldpipowitch
Copy link

@ctimmerm would it be possible to merge and release this? Is there something missing? Thank you ❤️

@gilbsgilbs gilbsgilbs force-pushed the is-axios-error-property branch from a52ff20 to 239ddda Compare September 29, 2019 12:46
@gilbsgilbs gilbsgilbs force-pushed the is-axios-error-property branch from 182b4d5 to f9510f9 Compare September 29, 2019 13:10
@ctimmerm
Copy link
Owner

ctimmerm commented Jan 4, 2020

Thanks!

@ctimmerm ctimmerm merged commit 036d1d2 into ctimmerm:master Jan 4, 2020
@gilbsgilbs gilbsgilbs deleted the is-axios-error-property branch January 4, 2020 08:46
@womcauliff
Copy link
Contributor

Glad to see this was merged! Can we expect this to be included in a release soon?
I have some error handling middleware which expects .isAxiosError to be true for axios network errors. This has resulted in my "negative case" tests failing because axios-mock-adapter errors are being treated differently than axios errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gilbsgilbs @donaldpipowitch @ctimmerm @womcauliff