Fix pagination bug in donations route #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminJohnson2204
changed the title
jrock-3
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the paging for the
GET /donationsroute.A prior PR (#52) fixing a SQL injection vulnerability changed the behavior of the
pageNumquery parameter. Previously, thenumDonationsquery parameter was used as the page size, and thepageNumparameter was used to determine the offset by multiplying it withnumDonations. That PR changed the behavior to usepageNumas the SQL offset directly, leading to incorrect behavior. For example, if you visit/donations?numDonations=5&pageNum=2, it gives you entries 2 through 6 in the table, when it should give you entries 5 through 9 (since page 1 should give you entries 0 through 4, that's how paging works).This PR changes the behavior back to the original so that paging will work as expected again (while maintaining security against SQL injection).