Setup pagination for dtt #49
Conversation
| } | ||
| }; | ||
| getData(); | ||
| }, [currentTab, currentPageNum, searchTerm]); |
There was a problem hiding this comment.
React Hook useEffect has a missing dependency: 'loadInfo'. Either include it or remove the dependency array.
There was a problem hiding this comment.
add load info to dependency array
There was a problem hiding this comment.
overall looks good, just some minor changes that can be done when we do merges @srukelman
| @@ -50,6 +50,7 @@ const AdminFilterBusinesses = () => { | |||
|
|
|||
| return ( | |||
| <div> | |||
|
|
|||
There was a problem hiding this comment.
Make sure you run yarn format
|
|
||
| const DonationSite = ({ donation_site, checkSet, setCheck, topCheckBox }) => { | ||
| const [individualCheckBox, setIndividualCheckBox] = useState(topCheckBox); |
There was a problem hiding this comment.
Change var name from individual checkbox to selectAllCheckBox
| ); | ||
| setCurrentDonationsNum(donationNumResponse.data[0]['count']); | ||
| setPageLimit(Math.ceil(donationNumResponse.data[0]['count'] / 10)); | ||
| // console.log(donationNumResponse.data.length); |
| } | ||
| }; | ||
| getData(); | ||
| }, [currentTab, currentPageNum, searchTerm]); |
There was a problem hiding this comment.
add load info to dependency array
| setCheckedSet(newCheckedSet); | ||
| } else { | ||
| const newCheckedSet = new Set(); | ||
| setCheckedSet(newCheckedSet); | ||
| } | ||
| }; | ||
|
|
||
| const handleSearch = event => { | ||
| setSearchTerm(event.target.value.split(' ').join('+')); |
|
Looks great, I tried some test cases and ran into this issue:
I went to the last page, then utilized the search, which then caused the page numbering to get messed up. Make sure you are resetting the page numbers and everything when the user uses the search. |
Fixes #44 : pagination, search, and css done for donation tracking table