Filter buttons admin dashboard #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iltration and pagination to AdminDashboard
ctc-devops
reviewed
Feb 16, 2024
| } | ||
| }; | ||
| getData(); | ||
| }, [currentTab, currentPageNum]); |
There was a problem hiding this comment.
React Hook useEffect has missing dependencies: 'businessDictionary' and 'loadInfo'. Either include them or remove the dependency array.
Xire7
requested changes
Feb 17, 2024
src/App.jsx
Outdated
Comment on lines
17
to
23
| <Navbar | ||
| {/* <Navbar | ||
| showContactUs={true} | ||
| title={''} | ||
| showSettings={false} | ||
| excelDownload={false} | ||
| backButton={true} | ||
| /> | ||
| /> */} |
There was a problem hiding this comment.
If this was commented out to test code, remember to uncomment it out when merging for development.
| const changeTab = async (tab) => { | ||
| setCurrentTab(tab); | ||
| setCurrentPageNum(1); | ||
| //loadInfo(tab); |
There was a problem hiding this comment.
remove commented out unused code
Comment on lines
38
to
39
| // const businessResponse = await backend.get(`/business/?businessLimit=10&pageNum=${currentPageNum}&tab=${tab}`); | ||
| // setBusinessDictionary(businessResponse.data); |
Comment on lines
119
to
120
| //const response = await backend.get('/business'); | ||
| //setData(response.data); |
| @@ -3,8 +3,10 @@ import './AdminDashboard.module.css'; | |||
| import { useBackend } from '../../contexts/BackendContext'; | |||
| import { useEffect, useState } from 'react'; | |||
| import { Box } from '@chakra-ui/react'; | |||
| //import { ChevronRightIcon, ChevronLeftIcon } from '@chakra-ui/icons'; | |||
| const [businessDictionary, setBusinessDictionary] = useState([]); | ||
| const [currentBusinessNum, setCurrentBusinessNum] = useState(0); | ||
| const [currentPageNum, setCurrentPageNum] = useState(1); | ||
| const [currentTab, setCurrentTab] = useState('Active'); //change to all once all page is implemented |
There was a problem hiding this comment.
good comment, just need to backtrack to changing the state to all when that page is implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31