src: fix dead code in RandomPrimeTraits

PR-URL: nodejs#37083 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
ctavan · Jan 29, 2021 · 0a993e1 · 0a993e1
1 parent 17467d1
commit 0a993e1
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/crypto/crypto_random.cc b/src/crypto/crypto_random.cc
@@ -110,8 +110,7 @@ Maybe<bool> RandomPrimeTraits::AdditionalConfig(
       return Nothing<bool>();
     }
     ArrayBufferOrViewContents<unsigned char> add(args[offset + 2]);
-    BN_bin2bn(add.data(), add.size(), params->add.get());
-    if (!params->add) {
+    if (BN_bin2bn(add.data(), add.size(), params->add.get()) == nullptr) {
       THROW_ERR_INVALID_ARG_VALUE(env, "invalid options.add");
       return Nothing<bool>();
     }
@@ -124,8 +123,7 @@ Maybe<bool> RandomPrimeTraits::AdditionalConfig(
       return Nothing<bool>();
     }
     ArrayBufferOrViewContents<unsigned char> rem(args[offset + 3]);
-    BN_bin2bn(rem.data(), rem.size(), params->rem.get());
-    if (!params->rem) {
+    if (BN_bin2bn(rem.data(), rem.size(), params->rem.get()) == nullptr) {
       THROW_ERR_INVALID_ARG_VALUE(env, "invalid options.rem");
       return Nothing<bool>();
     }