Skip to content
This repository was archived by the owner on Apr 10, 2021. It is now read-only.

Refactor spec file#75

Merged
ctaggart merged 2 commits intoctaggart:masterfrom
rylev:refactor-spec
Oct 29, 2020
Merged

Refactor spec file#75
ctaggart merged 2 commits intoctaggart:masterfrom
rylev:refactor-spec

Conversation

@rylev
Copy link
Contributor

@rylev rylev commented Oct 29, 2020

This help me understand the spec file a lot better. Feel free to reject the changes if you don't find it helpful.

Copy link
Owner

@ctaggart ctaggart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rylev
Copy link
Contributor Author

rylev commented Oct 29, 2020

@ctaggart the test that's failing here seems to also be failing on master. Can you confirm?

@ctaggart
Copy link
Owner

I can confirm. The integration test is failing because I changed the stable spec Azure/azure-rest-api-specs#11317. Just update the value to 197.

@ctaggart ctaggart merged commit 99721a9 into ctaggart:master Oct 29, 2020
@rylev rylev deleted the refactor-spec branch October 30, 2020 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants