This repository was archived by the owner on Apr 16, 2020. It is now read-only.
Development dependency for SourceLink.Copy.PdbFiles #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@paulomorgado I thought you did that already as #331. |
Contributor
Author
|
For some reason, that one seems to have escaped. |
Owner
|
Can you make sure you have the latest from master merged in? I see it here: |
ctaggart
reviewed
Jun 7, 2018
| <!-- https://github.com/NuGet/Home/wiki/Adding-nuget-pack-as-a-msbuild-target --> | ||
| <IncludeBuildOutput>false</IncludeBuildOutput> | ||
| <!--<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>--> | ||
| <DevelopmentDependency>True</DevelopmentDependency> |
Owner
There was a problem hiding this comment.
Added <DevelopmentDependency>True</DevelopmentDependency> to build NuGet packages with the developmentDependency metadata
paulomorgado
force-pushed
the
DevelopmentDependency
branch
from
6c877ab to
e1097f8
Compare
Contributor
Author
|
Now that you mention it, I did had the impression that I had already sent a PR for this. But when I checked I checked https://www.nuget.org/packages/SourceLink.Copy.PdbFiles/2.8.1 and saw it was missing it, I thought I had forgotten. |
ctaggart
changed the title
Owner
|
2.8.2 published. Thanks! |
Contributor
Author
|
No! Thanks for providing the tools! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added True to build NuGet packages with the developmentDependency metadata