Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with audio generation steps #67

Merged
merged 3 commits into from
May 22, 2024

Conversation

rcottingham
Copy link
Collaborator

Added a section on the steps taken to generate AAC / AC4 / EAC3 audio content.

Added a section on the steps taken to generate AAC / AC4 / EAC3 audio content.
@rbouqueau
Copy link
Collaborator

Thanks!

The text is fine. However it doesn't allow to fully reproduce (based on pre-encoded content for properietary codecs). Personally I would have found great that it re-uses the existing code to package.

Waiting for others' approvals to merge.

@jpiesing
Copy link
Contributor

My main comment is that, for Dolby encoding, the reference to Hybrik is to a tool available to anyone under commercial terms. There's not really enough information there for someone else to regenerate the content.

@rcottingham
Copy link
Collaborator Author

Hi @rbouqueau, thanks for the feedback. I understand your position and agree that a single script would be the ideal. Unfortunately it's not the way we have generated the content and changing now would require significant re-work. (Our commercial obligations were to produce appropriate audio for tests - which has been done).

Apologies for this, but I would be grateful if you can merge this PR. I can then update with further details re Dolby encoding using Hybrik as requested by @jpiesing.

Thanks, Richard.

Added additional information about encoding using Dolby Hybrik tool.
@rcottingham
Copy link
Collaborator Author

Hi @rbouqueau please can you merge the changes in patch-2 (added more info on encoding Dolby). Many Thanks, Richard.

@rbouqueau
Copy link
Collaborator

@rcottingham sorry for the delay. I'm concerned about the reproducibility and maintenance. Thus would it be ok to add yourself/your-company as a maintainer at the top of these sections?

Added a section on ownership
@rbouqueau rbouqueau merged commit 0d6f42e into cta-wave:master May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants