Fixed unknown configs being silently ignored #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
reviewed
Dec 4, 2024
maxnoe
previously approved these changes
Dec 4, 2024
maxnoe
reviewed
Dec 4, 2024
Damn... this is a cross issue with the switch to minio, we uploaded a new file after Gareth moved the data |
Tobychev
approved these changes
Dec 4, 2024
maxnoe
approved these changes
Dec 4, 2024
|
Gareth uploaded the file, CI is passing now |
Analysis Details0 Issues
Coverage and Duplications
Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where if a configuration file with unknown file extension is passed to a tool, e.g.
--config myconf.confinstead of--config myconf.yaml, it was silently ignored. Config files must now have one of the following extensions to be recognized: yml, yaml, toml, json, py, and if not aToolConfigurationErroris raised.