Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tag requires double click after first tag #877

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix tag requires double click after first tag #877

merged 1 commit into from
Oct 11, 2024

Conversation

wilco375
Copy link
Contributor

Summary

Fixes #862

@lodewiges
Copy link
Contributor

tested and works

@wilco375 wilco375 added this pull request to the merge queue Oct 11, 2024
DrumsnChocolate
DrumsnChocolate approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@DrumsnChocolate DrumsnChocolate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is also a sign of something not properly tearing down, but maybe that's just me? I would for some reason have expected selectApi to have been cleared. But I suppose the PhotoTags instance never really 'disappears' to Ember?

Merged via the queue into staging with commit 8b30b52 Oct 11, 2024
3 checks passed
@wilco375 wilco375 deleted the bugfix/tag-double-click branch October 11, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lodewiges lodewiges lodewiges approved these changes

@DrumsnChocolate DrumsnChocolate DrumsnChocolate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tagging user in photo requires two clicks
3 participants
@wilco375 @lodewiges @DrumsnChocolate