Generalized MOM restart function#1
Closed
marshallward wants to merge 3 commits into
Closed
Conversation
Author
|
I reckon we should get feedback from @adcroft and @Hallberg-NOAA before adding this to the PR. |
adcroft
reviewed
Jul 3, 2023
adcroft
left a comment
adcroft
left a comment
There was a problem hiding this comment.
I like this revision. It implements what we discussed the restarts should look like.
Author
|
I added a new feature which creates the |
Author
|
@cspencerjones If you like, I can handle this one over at NOAA-GFDL/MOM6, entirely up to you though. |
As described in issue mom-ocean#372, I would like to be able to create restart files that contain information about the particle location. These files will be written at the same time as other restart files. I cannot add these calls directly to the driver, because the driver does not have information about the particle location. We have added save_MOM6_internal_state as a subroutine in MOM.F90, and we added calls to this subroutine from each of the drivers. We hope this will allow for more new packages to write restart files in the future. Co-authored by Spencer Jones <spencerjones@tamu.edu>
This patch merges the internal `save_restart` function with the new `save_MOM6_internal_state` function into a new general MOM restart function. It also makes an effort to eliminate `MOM_restart` as a driver dependency, narrowing the required MOM API for existing and future drivers. Also removes the `restart_CSp` argument from `MOM_wave_interface_init`, since it appeared to be used for nothing.
MOM simulations typically abort of the restart directory (usually RESTART) are absent. This patch adds POSIX support for mkdir() and creates the directory if it is missing.
marshallward
force-pushed
the
new_save_restart
branch
from
ebb0344 to
283d100
Compare
Author
|
These changes will be handled in a separate PR to dev/gfdl. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch merges the internal
save_restartfunction with the newsave_MOM6_internal_statefunction into a new general MOM restart function.It also makes an effort to eliminate
MOM_restartas a driver dependency, narrowing the required MOM API for existing and future drivers.Also removes the
restart_CSpargument fromMOM_wave_interface_init, since it appeared to be used for nothing.