Modify pvc controller to reconcile encryptionkeyrotation

[black-dragon74]

This patch modified the PVC controller so that it
reconciles the pvcs for encryptionkeyrotation
operations.

Note: Please review the most recent commit only as the rest of them are unrelated to this feature. The extra commits are due to this PR being based off of impl-pvkr branch.

Depends-on: #608

Regards

[Madhu-1]

some nits, looks like this also need larger refactor to avoid duplication, lets address that later

[Madhu-1]

LGTM. reviewed only last commit.

[black-dragon74]

LGTM. reviewed only last commit.

There was a logic bug on line 712. Along with that I had forgotten to add the field indexer for EKRCronJobs owned by PVCs.

Both issues are fixed and a thorough testing has been done on my end.

err = r.Client.Update(ctx, krcJob) // was err = r.Client.Update(ctx, newKrcJob)

Code for new field indexer (lines 301-322)

err = mgr.GetFieldIndexer().IndexField(
		context.Background(),
		&csiaddonsv1alpha1.EncryptionKeyRotationCronJob{},
		jobOwnerKey,
		func(rawObj client.Object) []string {
			job, ok := rawObj.(*csiaddonsv1alpha1.EncryptionKeyRotationCronJob)
			if !ok {
				return nil
			}
			owner := metav1.GetControllerOf(job)
			if owner == nil {
				return nil
			}
			if owner.APIVersion != "v1" || owner.Kind != "PersistentVolumeClaim" {
				return nil
			}

			return []string{owner.Name}
		})
	if err != nil {
		return err
	}

Regards

[nixpanic]

Please combine commits in the PR that are related together. Ideally you have a few commits left that cleanly implement a functionality and also include the improvements for review comments.

[black-dragon74]

Please combine commits in the PR that are related together. Ideally you have a few commits left that cleanly implement a functionality and also include the improvements for review comments.

Only the last commit in this PR is related to the PVC controller. Rest are due to this PR being rebased off of the PR implementing the controllers for key rotation.

I will merge the commits in that PR and will update this one too :)

[black-dragon74]

Please combine commits in the PR that are related together.

PTAL @nixpanic

[nixpanic]

Added a few small comments. Ideally every function that is added contains a description of what it does. This is more important for larger functions (say > 15-20 lines of code).

[nixpanic]

only reviewed the last commit, because everything else is part of #608

Pull request has been modified.

[black-dragon74]

Rebased it to main.

/cc @Rakshith-R @nixpanic @Madhu-1

[black-dragon74]

@Rakshith-R Please trigger a rebase as well. There is some membership issues with my acct that needs to be ironed out.

[Madhu-1]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased