controller: improve error for missed start times in cronjob #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
approved these changes
Jun 21, 2023
nixpanic
approved these changes
Jun 21, 2023
The reclaimspacecronjob may miss too many runs due to the following reasons: - low startingDeadlineSeconds - clock skew - (added now) when user has reduced schedule which in turn leads to the new interval being < 100 times of old interval, aka >100 missed runs. This issue only occurs when user changes schedule which drastically reduces interval by more than 100 times. Error message is improved to ask user to delete and recreate cronjob to overcome this issue. Signed-off-by: Rakshith R <[email protected]>
Rakshith-R
force-pushed
the
schedule-change
branch
from
763b5d2 to
5b27fe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reclaimspacecronjob may miss too many runs due to the following reasons:
This issue only occurs when user changes schedule which drastically reduces interval by more than 100 times. Error message is improved to ask user to delete and recreate cronjob to overcome this issue.