-
Notifications
You must be signed in to change notification settings - Fork 7
Feat/military affiliation #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/military affiliation #426
Conversation
jsandoval81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking solid 👍
This was a mostly code review. I'll take a deeper dive in the UI on the next pass.
webroot/src/components/MilitaryDocumentRow/MilitaryDocumentRow.vue
Outdated
Show resolved
Hide resolved
webroot/src/components/SelectedStatePurchaseInformation/SelectedStatePurchaseInformation.ts
Show resolved
Hide resolved
webroot/src/pages/UpdateMilitaryStatus/UpdateMilitaryStatus.less
Outdated
Show resolved
Hide resolved
jsandoval81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks solid. Just a few trailing items that are pretty minor.
|
@jlkravitz This is ready for your review. |
jlkravitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! a few small nits.
jlkravitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isabeleliassen Good to merge.
Requirements List
Description List
FinalizePrivilegePurchasepage andSelectedStatePurchaseInformationcomponent to refer to both the state and user's military status to make a military discount determinationInputRadioGroupcomponent causing multi-line labels to break layoutTesting List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsCloses #281
Notes: