Truncate floats when passed to IntParameter #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should fix #29.
With v0.8.0, I made a change to
IntParameter
whereby if it was passed a float, an error was raised. In the past, the float would have silently converted to an int. This PR makes a change so that, in such a circumstance, the floating point value is truncated and an warning is issued.In #29, this was a problem when loading metadata from pymt_cem because it contained the following section in its parameters file,
Notice the default is a float but the type is int.