Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use functions from solver module in Diffusion class #132

Merged
merged 7 commits into from
Sep 11, 2023

Conversation

mdpiper
Copy link
Member

@mdpiper mdpiper commented Sep 8, 2023

In this PR, I modified the ivy-diffusion Diffusion class to use the functions from the solver module. This provides a nice way to show:

  • relative imports
  • using/reusing code from another module

In order to make relative imports work, I had to include a __init__.py file in the ivy-diffusion package (see #131). I had been hoping to avoid this extra step.

I also changed the way the time step is calculated in the solver module. It was way unstable otherwise.

This resolves #129.

@mdpiper mdpiper merged commit c6c9331 into main Sep 11, 2023
17 checks passed
@mdpiper mdpiper deleted the mdpiper/use-solver-module branch September 11, 2023 18:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use functions from solver module in Diffusion class
1 participant