Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't separately test initialize(); allow testing even if initial value of array is NaN #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sc0tts
Copy link
Contributor

@sc0tts sc0tts commented Apr 25, 2017

Three suggested changes:

  1. Re-ordered text around the non-testing of test_get_value(self) [Purely cosmetic]

  2. Removed the test of initialize() because this is done in the setup before every test. And it was failing when I wasn't passing a config file to the routine because I was testing a BMI routine that could use, but didn't need, a specified config file

  3. In order to test get/set at indices, bmi-tester gets an array's values, increments the first value, and set's the first indices to that value. But I had initialized the arrays to NaN -- actually np.nan -- so the increment operation was causing an error. I import the math module to get access to math.isnan() so I can check for this condition and instead use the value "1" as the value that gets used in set_value_at_indices().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant