Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMake build #7

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Update CMake build #7

merged 4 commits into from
Oct 19, 2023

Conversation

mdpiper
Copy link
Member

@mdpiper mdpiper commented Oct 19, 2023

This PR makes three minor changes to the CMake build process:

  1. Inspired by @mwtoews in CMake: refactor a few items bmi-fortran#47, use GnuInstallDirs and variables for standard install locations.
  2. Update the minimum required CMake version to remove a deprecation warning.
  3. Suggest where to install the specification when using a conda environment.

@mdpiper
Copy link
Member Author

mdpiper commented Oct 19, 2023

It looks like I need to update the stale CI first.

@mdpiper mdpiper marked this pull request as ready for review October 19, 2023 22:12
@mdpiper mdpiper merged commit aabb8e8 into master Oct 19, 2023
4 checks passed
@mdpiper mdpiper deleted the mdpiper/update-cmake-build branch October 19, 2023 23:12
@mdpiper mdpiper mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdpiper