Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove options for babelize generate command #91

Merged
merged 13 commits into from
Mar 12, 2024

Conversation

mcflugen
Copy link
Member

@mcflugen mcflugen commented Mar 7, 2024

This pull requests simplifies the babelize generate command by removing all command line options and no longer prompting a user for input. Instead, it just prints a sample babelize config file for a user to edit. The options and prompts added a lot of extra code for little benefit.

@mcflugen
Copy link
Member Author

What do you think of this @mdpiper? Are you ok with just printing out a sample config file that someone can then edit? It seemed like being able to control the contents of the config file through the command line was overkill.

@mdpiper
Copy link
Member

mdpiper commented Mar 12, 2024

I think it's a really good idea. All the command-line options made it a bit cumbersome. Frankly, I've just been editing old (possibly out of date) babel.toml files, so this would be an improvement for me.

@mcflugen
Copy link
Member Author

Thanks @mdpiper. I've also renamed the command from babelize generate to babelize sample-config as that seems more descriptive of what it does.

@mcflugen mcflugen merged commit 330625e into develop Mar 12, 2024
11 of 35 checks passed
@mcflugen mcflugen deleted the mcflugen/remove-cli-prompts branch March 12, 2024 17:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants