Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return locks on PROPFIND when requested #4107

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Return locks on PROPFIND when requested #4107

merged 1 commit into from
Aug 9, 2023

Conversation

kobergj
Copy link
Contributor

@kobergj kobergj commented Aug 9, 2023

Locks would not be properly returned when another prop was requested. This fixes it.

@kobergj kobergj requested review from a team, labkode, ishank011 and glpatcern as code owners August 9, 2023 10:21
lookacat
lookacat approved these changes Aug 9, 2023
View reviewed changes
Copy link

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (as far as my backend/go knowledge goes)

@butonic butonic merged commit 3ceaf17 into cs3org:edge Aug 9, 2023
@kobergj kobergj deleted the ReturnLockWhenRequested branch August 9, 2023 11:39
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lookacat lookacat lookacat approved these changes

@butonic butonic butonic approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobergj @lookacat @butonic