Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly handle upload to non existent folders #1901

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Jul 19, 2021

When a new file was uploaded to a non existent folder the response code was incorrect.

@update-docs
Copy link

update-docs bot commented Jul 19, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@C0rby C0rby force-pushed the upload-nonexistent-parent branch 3 times, most recently from fae4fd3 to b2567a7 Compare July 19, 2021 21:25
@C0rby C0rby requested review from butonic, ishank011, labkode and refs July 19, 2021 21:47
@C0rby C0rby marked this pull request as ready for review July 19, 2021 21:47
phil-davis
phil-davis previously approved these changes Jul 21, 2021
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations - test failures fixed.

butonic
butonic previously approved these changes Jul 21, 2021
labkode
labkode previously approved these changes Jul 21, 2021
@labkode
Copy link
Member

labkode commented Jul 21, 2021

@C0rby a rebase would do it

@C0rby C0rby dismissed stale reviews from labkode, butonic, and phil-davis via dd9414b July 21, 2021 08:03
@C0rby C0rby force-pushed the upload-nonexistent-parent branch from b2567a7 to dd9414b Compare July 21, 2021 08:03
@ishank011 ishank011 merged commit 1fb0bd6 into cs3org:master Jul 22, 2021
@C0rby C0rby deleted the upload-nonexistent-parent branch July 22, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants