Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation #1

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Initial implementation #1

merged 5 commits into from
Jul 31, 2024

Conversation

diocas
Copy link
Contributor

@diocas diocas commented Jul 16, 2024

No description provided.

Copy link
Contributor Author

@diocas diocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked the tests yet, but here's my initial review.

It looks very good (good job!), but there are comments to address.

One comment on the commits: I see 3 commits related to creation of an auth file, then a fix, then its removal (because you put another in the src folder). So I would remove all those 3 commits, since they have no change. In general, I like to see a PR with only the commits that have relevance to the final state (unless there's some relevant middle step) and split into logical areas.

examples/file_apy_example.py Outdated Show resolved Hide resolved
examples/file_apy_example.py Outdated Show resolved Hide resolved
examples/file_apy_example.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
src/auth.py Outdated Show resolved Hide resolved
src/file.py Outdated Show resolved Hide resolved
src/file.py Outdated Show resolved Hide resolved
src/file.py Show resolved Hide resolved
src/file.py Show resolved Hide resolved
src/file.py Show resolved Hide resolved
@diocas diocas assigned diocas and rawe0 and unassigned diocas Jul 16, 2024
@diocas diocas requested a review from glpatcern July 16, 2024 13:14
@glpatcern
Copy link
Member

Nice job indeed! I left only a few "response" comments and will need to go through the code more in details, but it's a good start @rawe0 👍

@glpatcern
Copy link
Member

BTW I have created a https://github.com/cs3org/wopiserver/tree/cs3client branch and invited @rawe0 to the cs3org Organization, so that we can also start looking at the modifications of the wopiserver to adopt this library. We can do something similar for the cs3api4lab repo.

src/auth.py Outdated Show resolved Hide resolved
src/auth.py Outdated Show resolved Hide resolved
src/auth.py Outdated Show resolved Hide resolved
src/auth.py Outdated Show resolved Hide resolved
src/auth.py Outdated Show resolved Hide resolved
src/file.py Outdated Show resolved Hide resolved
src/file.py Show resolved Hide resolved
src/file.py Show resolved Hide resolved
src/file.py Outdated Show resolved Hide resolved
src/file.py Show resolved Hide resolved
examples/file_apy_example.py Outdated Show resolved Hide resolved
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding the suggested changes, I think we can merge and then we'll take it from there by testing the wopiserver, e.g. we see how the Resource class really works

src/auth.py Show resolved Hide resolved
src/auth.py Outdated Show resolved Hide resolved
src/auth.py Outdated Show resolved Hide resolved
src/auth.py Outdated Show resolved Hide resolved
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diocas let's merge?

@diocas
Copy link
Contributor Author

diocas commented Jul 31, 2024

Go ahead @glpatcern (I cannot :) )

@glpatcern glpatcern merged commit 2d52375 into main Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants