-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked the tests yet, but here's my initial review.
It looks very good (good job!), but there are comments to address.
One comment on the commits: I see 3 commits related to creation of an auth file, then a fix, then its removal (because you put another in the src folder). So I would remove all those 3 commits, since they have no change. In general, I like to see a PR with only the commits that have relevance to the final state (unless there's some relevant middle step) and split into logical areas.
Nice job indeed! I left only a few "response" comments and will need to go through the code more in details, but it's a good start @rawe0 👍 |
BTW I have created a https://github.com/cs3org/wopiserver/tree/cs3client branch and invited @rawe0 to the cs3org Organization, so that we can also start looking at the modifications of the wopiserver to adopt this library. We can do something similar for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After adding the suggested changes, I think we can merge and then we'll take it from there by testing the wopiserver, e.g. we see how the Resource
class really works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diocas let's merge?
Go ahead @glpatcern (I cannot :) ) |
No description provided.