Witchcraft error catching #716
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you merge origin react into your branch and repair the merge? Thanks. |
|
Hi, can you make |
|
Doing so makes instance of not work. Not sure whu |
|
Try this: microsoft/TypeScript#13965 |
|
@kpsuperplane Pull from e45lee/error-handling-fixes |
|
OK I'm going to merge your branch with the Error handling fixed so I'll close this for now. |
Merged
yuliswe
reviewed
Mar 24, 2017
| super(message); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
So what's the point of this class? It just sets __proto__ to Error?
There was a problem hiding this comment.
That's a fix to repair the prototype chain so instanceof works properly. See #721.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You might need to rewrite a lot of the error stuff to work with this..