-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved unicode support in mutator, flattener, and more #2662
Open
bohendo
wants to merge
17
commits into
dev
Choose a base branch
from
fix-unicode-src-mappings
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solc, foundry, hardhat, everything reports source_map offsets denominated in bytes (solidity#14733 is a false positive). And (almost) all slither detectors/properly properly index the source code byte-wise. Great.
But some tools, notably the mutator and flattener, use per-byte offsets to index strings per-character. Once this PR is merged, they will not.
Summary of changes:
source_mapping.content
to index source code correctly and used this property instead of manual indexing in flat/mutate toolssrc_mapping
,source_code
, andutf8
encodings to ensure we aren't applying byte-offsets to strings anywhere else"utf-8"
and"utf8"
to just the latterNote that the last 3 of these were merged into this branch from PR#2648 bc most of the changes in that PR would have needed to be duplicated in this one.