Support NoColor and --no-color #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
anishnaik
reviewed
Sep 7, 2023
|
@Exca-DK left some comments, mostly around unit testing. Otherwise, PR is looking great. Once those are resolved, I will do one more review and some more testing and then we can merge. Super super excited for you to be our first external contributor! |
|
I don't see any comments 😅 |
anishnaik
requested changes
Sep 8, 2023
|
@Exca-DK apologies - I forgot to submit my review. Please see above for additional comments. |
|
@Exca-DK approved the PR. Feel free to squash and merge whenever you want |
damilolaedwards
pushed a commit
that referenced
this pull request
Nov 16, 2023
* Console output with optional coloring * optional Colorize * LF and CRLF line endings * update no-color flag description * code review changes --------- Authored-by: Exca-DK <[email protected]>
s4nsec
pushed a commit
that referenced
this pull request
Jul 9, 2024
* Console output with optional coloring * optional Colorize * LF and CRLF line endings * update no-color flag description * code review changes --------- Authored-by: Exca-DK <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #217