Fix deprecation warning on JSON::PullParser#7
Closed
wout wants to merge 1 commit into
Closed
Conversation
Member
|
I've pushed a8b4c4d into |
Author
|
Yeah, that's what I thought, the failing specs are unrelated. Haven't had the time to look at it, though. |
Member
|
@wout Tracked it down, fix is on the way / see crystal-lang/crystal#8789 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #5. However, there are quite a few failing specs:
Most of them are related I think, because they have similar failures: