Skip to content

Fix handle global --help flag#664

Closed
straight-shoota wants to merge 1 commit intocrystal-lang:masterfrom
straight-shoota:fix/global-help
Closed

Fix handle global --help flag#664
straight-shoota wants to merge 1 commit intocrystal-lang:masterfrom
straight-shoota:fix/global-help

Conversation

@straight-shoota
Copy link
Member

Resolves #649

@ysbaddaden
Copy link
Contributor

That won't catch shards --local --help for example, and shards install --help also runs the install command then prints the help 😞

@ysbaddaden
Copy link
Contributor

I'm trying to find something, but it doesn't work as intended so far.

@straight-shoota
Copy link
Member Author

My intent was to do a simple fix for the patch release to address the most common use case shards --help.
But the behaviour of shards install --help certainly isn't acceptable either.

I think we have the following alternative steps forward:

@ysbaddaden
Copy link
Contributor

ysbaddaden commented Jan 20, 2025

I think this works restores the previous behavior: #665

@ysbaddaden
Copy link
Contributor

Refactoring would indeed be 👍

And having a better support for sub-commands right into OptionParser would be ❤️

@straight-shoota
Copy link
Member Author

Resolved by #665

@straight-shoota straight-shoota deleted the fix/global-help branch January 21, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shards --help invokes install subcommand

2 participants