Merged
Conversation
straight-shoota
changed the title
Member
beta-ziliani
left a comment
beta-ziliani
left a comment
There was a problem hiding this comment.
Excellent summary! Just a few comments for improving the text.
Co-authored-by: Beta Ziliani <beta@manas.tech>
Co-authored-by: George Dietrich <github@dietrich.house>
beta-ziliani
approved these changes
Nov 12, 2024
Member
beta-ziliani
left a comment
beta-ziliani
left a comment
There was a problem hiding this comment.
LGTM, but of course I'd wait for Julien's input
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/new-event-loop-unix-call-for-reviews-tests/7207/22 |
ysbaddaden
reviewed
Nov 14, 2024
Co-authored-by: Julien Portalier <julien@portalier.com>
Co-authored-by: Julien Portalier <julien@portalier.com>
ysbaddaden
approved these changes
Nov 18, 2024
beta-ziliani
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been merged. The RFC text is available at: https://github.com/crystal-lang/rfcs/blob/main/text/0009-lifetime-event_loop.md
This RFC is a bit late to the party because the implementation is already mostly complete in crystal-lang/crystal#14996
It still serves as documentation for these quite significant changes to the runtime. Reviews and comments are appreciated nevertheless.
Preview: https://github.com/crystal-lang/rfcs/blob/rfc/lifetime-event_loop/text/0009-lifetime-event_loop.md