Save fiber stacks on Fiber directly instead of using Hash#27
Open
ysbaddaden wants to merge 8 commits intomainfrom
Open
Save fiber stacks on Fiber directly instead of using Hash#27ysbaddaden wants to merge 8 commits intomainfrom
ysbaddaden wants to merge 8 commits intomainfrom
Conversation
Also allows to generate backtraces for Slice(Void*) directly (no need for an Array anymore).
This comment was marked as outdated.
This comment was marked as outdated.
ysbaddaden
commented
Mar 28, 2025
straight-shoota
pushed a commit
to crystal-lang/crystal
that referenced
this pull request
Apr 17, 2025
…15615) Internal refactor: allows to generate a decoded backtrace for any given instruction pointer, without requiring an `Array` or an `Exception::CallStack` object. My use case is crystal-lang/perf-tools#27 where I use slices and where I could merely call this helper method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a few things:
Fiberinstead of storing each into a different globalHash;Fiber.each(thread safe linked list);Fiber.inactiveanymore;track_fiberto be a macro anymore (renamedcaller_stack);The above allows us to not need an explicit lock anymore: we're always setting the stack for the current fiber, and we can have a few checks to make sure we can use said stack from another thread.
Which leads me to the last point: we can generate a backtrace from a
Slice(Void*)directly (with a few changes) and we can store stacks asSlice(Void*)directly instead ofArray(Void*).The stacks slice is a struct and if its size won't change, then only the pointer will, so we wouldn't need thread synchronization... except for one caveat: the size can change from 0 to N (see comments) so we check for null pointer and size == 0 (to be resilient to any parallel write reorder), before deciding to use the stack.I'm having some second thoughts about that. Maybe an Array would be safer: we'd merely update a pointer in place 🤔I still save the stack as
Array(Void*)then expose views into the array asSlice(Void*). The underlying buffer size is either 0 or DEPTH + SKIP.