Skip to content

Fix touch shard.lock after checkout #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 2 commits into from
Jan 30, 2025
Merged

Fix touch shard.lock after checkout #350

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91f523b
Drop printing readelf
straight-shoota Jan 29, 2025
7d17009
Fix touch `shard.lock` after checkout
straight-shoota Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions linux/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,14 @@ ARG musl_target
RUN git clone https://github.com/crystal-lang/shards \
&& cd shards \
&& git checkout ${shards_version} \
# FIXME: This is a workaround for shards' Makefile not touching `shard.lock`
# when SHARDS=false
&& touch shard.lock \
&& make SHARDS=false CRYSTAL=/crystal/bin/crystal \
FLAGS="--stats --target ${musl_target} --static ${release:+--release}" \
\
&& bin/shards --version \
&& ( (readelf --program-headers bin/shards | grep -q "Elf file type is EXEC") || { echo 'shards is not statically linked'; exit 1; }) \
&& readelf --program-headers bin/shards
&& ( (readelf --program-headers bin/shards | grep -q "Elf file type is EXEC") || { echo 'shards is not statically linked'; exit 1; })

COPY --from=bdwgc /bdwgc/.libs/libgc.a /libgc-debian.a

Expand Down