Upgrade ruby version for omnibus #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
force-pushed
the
omnibus-ruby-3-2-2
branch
2 times, most recently
from
e30a182 to
26c643b
Compare
straight-shoota
approved these changes
Nov 12, 2023
miry
force-pushed
the
omnibus-ruby-3-2-2
branch
from
26c643b to
0673532
Compare
|
@straight-shoota I think it is ready to merge, while tests were passed. |
straight-shoota
approved these changes
Dec 22, 2023
Upgrade from 2.7.3 to 3.2.2. Ruby 2.7.3 is not supported anymore.
miry
force-pushed
the
omnibus-ruby-3-2-2
branch
from
0673532 to
b5259da
Compare
|
UPDATE: Rebased against distribution-scripts master and tested against latest crystal in CI: NOTE: triggered with: $ curl --request POST \
--url "https://circleci.com/api/v2/project/github/miry/crystal/pipeline" \
--header "Circle-Token: ${CIRCLECI_API_KEY}" \
--header "content-type: application/json" \
--data '{"branch":"test-darwin","parameters":{"run_distribution_scripts_tests":true,"distribution-scripts-repo":"https://github.com/miry/distribution-scripts.git","distribution-scripts-version":"omnibus-ruby-3-2-2"}}' |
straight-shoota
approved these changes
Jan 2, 2024
beta-ziliani
approved these changes
Jan 2, 2024
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
Apr 8, 2024
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@46c295d This includes the following changes: * crystal-lang/distribution-scripts#296 * crystal-lang/distribution-scripts#297 * crystal-lang/distribution-scripts#294 * crystal-lang/distribution-scripts#291 * crystal-lang/distribution-scripts#274 * crystal-lang/distribution-scripts#286 * crystal-lang/distribution-scripts#281 * crystal-lang/distribution-scripts#270 * crystal-lang/distribution-scripts#263 * crystal-lang/distribution-scripts#273
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade from 2.7.3 to 3.2.2.
Ruby 2.7.3 is not supported by ruby core team anymore.
Testing
Tested localy with my custom made branch: https://github.com/miry/distribution-scripts/tree/125-support-arm
Post
It would allow to upgrade ruby in CI https://github.com/crystal-lang/crystal/blob/2543c094301e700c0489ae708309dc0e1cfebd8b/.circleci/config.yml#L297