Feat: Enum::StringConverter(T)#9887
Closed
caspiano wants to merge 2 commits intocrystal-lang:masterfrom
Closed
Conversation
4a33be8 to
4a76b58
Compare
4a76b58 to
5b3f7d3
Compare
Contributor
|
My 2c:
|
Contributor
Author
|
@Sija Yeah, I agree, I'd much prefer I'll whip up another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Enum::StringConverter(T), a converter to be used withJSON::Serializableto write and readan
Enumexclusively as aString.This is useful if you wish to serialise to
String, instead ofthe default of a number representation of the
Enum.Closes #9881
Includes fixes to minor typos in a few serialization examples.
Usage: