Skip to content

Disable AArch64 jobs on forks#9582

Merged
waj merged 1 commit intocrystal-lang:masterfrom
waj:fix/disable-arm-build-on-forks
Jul 8, 2020
Merged

Disable AArch64 jobs on forks#9582
waj merged 1 commit intocrystal-lang:masterfrom
waj:fix/disable-arm-build-on-forks

Conversation

@waj
Copy link
Member

@waj waj commented Jul 6, 2020

Now that #9508 is merged, the workflow is being executed on every commit, even on repository forks. I don't know a better way to disable it. I tried with an environment variable, but seems like unfortunately they are not available at the job.if level.

@waj waj requested a review from jhass July 6, 2020 23:37
@jhass
Copy link
Member

jhass commented Jul 7, 2020

Well, only when the fork enables GitHub actions in the first place.

Why would you disable only the AArch64 workflow like this and not the others?

@oprypin
Copy link
Member

oprypin commented Jul 7, 2020

@jhass because it can't actually run without separate hardware

@jhass
Copy link
Member

jhass commented Jul 7, 2020

Ah well. Is this really an issue? Can't you just ignore the failures? For a long-term fork, disabling the workflow there is also super easy.

@waj
Copy link
Member Author

waj commented Jul 7, 2020

I found running the workflows in my fork is quite useful actually. The specs are executed even before sending the PR without any extra configuration.

@jhass
Copy link
Member

jhass commented Jul 7, 2020

If the jobs are skipped like this, are they rerun once you open a PR to branch?

@waj
Copy link
Member Author

waj commented Jul 7, 2020

If the jobs are skipped like this, are they rerun once you open a PR to branch?

Apparently, yes. They were run on this PR and skipped on my repo: https://github.com/waj/crystal/runs/843517722

Can't you just ignore the failures?

Sure, but it's annoying to see a red flag on every commit.

For a long-term fork, disabling the workflow there is also super easy.

I don't see any way that isn't deleting the yml file. GitHub is adding features to Actions all the time and I guess this might be a quite common issue. It wouldn't be strange that they add a better way to deal with this in the future, but for now seems to be an acceptable workaround to me.

@Blacksmoke16
Copy link
Member

I don't see any way that isn't deleting the yml file

Probably can go to Settings => Actions on your fork and choose the last option:
image

@waj
Copy link
Member Author

waj commented Jul 7, 2020

@Blacksmoke16 I know. I meant disabling just the AArch64 workflow.

Copy link
Member

@jhass jhass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh well, I really hope GH gets the story straight on self hosted runners. Too many edge cases.

@waj waj merged commit afc214d into crystal-lang:master Jul 8, 2020
@waj waj deleted the fix/disable-arm-build-on-forks branch July 8, 2020 17:23
asterite pushed a commit to asterite/crystal-1 that referenced this pull request Jul 18, 2020
@bcardiff bcardiff added this to the 1.0.0 milestone Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants