Make specs pass in non-IPv6 environments#9438
Merged
bcardiff merged 2 commits intocrystal-lang:masterfrom Jun 22, 2020
Merged
Conversation
It's 2020 and sadly IPv6 is not yet truly ubiquitous. While supported by all relevant operating systems, enabled, even just locally, in all relevant execution environments, not so much. Prominently Docker does not enable it in its default configuration.
jhass
added
kind:bug
oprypin
reviewed
Jun 6, 2020
straight-shoota
approved these changes
Jun 6, 2020
Contributor
|
Is there a reason to not use this? I am just curious. Line 79 in 4401e90 |
Member
Author
|
Mmh, I didn't see it tbh! But also no other specs seem to use these. Maybe you can send a separate pull request changing them all after this? Rather than introducing inconsistency in the specs here. |
waj
approved these changes
Jun 22, 2020
jhass
added
the
pr:ready-to-merge
bcardiff
removed
the
pr:ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's 2020 and sadly IPv6 is not yet truly ubiquitous. While supported by all relevant operating systems, enabled, even just locally, in all relevant execution environments, not so much. Prominently Docker does not enable it in its default configuration.