Merged
Conversation
I don't claim to understand why this is more correct, I just compared the LLVM IR from one failing spec to what Clang would generate for the equivalent code. It doesn't seemm to break any other specs
jhass
added
platform:aarch64
kind:bug
Collaborator
|
I really don't remember. The ABI was just ported from Rust. I'm not sure we need custom ABI nowadays. LLVM defines & applies the proper DataLayout for each target... |
Member
Author
waj
approved these changes
Jun 22, 2020
jhass
added
the
pr:ready-to-merge
bcardiff
removed
the
pr:ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't claim to understand why this is more correct, I just compared the LLVM IR from one failing spec to what Clang would generate for the equivalent code.
It doesn't seem to break any other specs.
@ysbaddaden I think you did the initial port? If you care and maybe remember why you set it like this, that would be much appreciated :)