Skip to content

make wait_readable and wait_writable public #8651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RX14 merged 1 commit into from
Jan 6, 2020
Merged

make wait_readable and wait_writable public #8651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/io/evented.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,13 @@ module IO::Evented
end
end

protected def wait_readable(timeout = @read_timeout)
# :nodoc:
def wait_readable(timeout = @read_timeout)
wait_readable(timeout: timeout) { |err| raise err }
end

protected def wait_readable(timeout = @read_timeout) : Nil
# :nodoc:
def wait_readable(timeout = @read_timeout) : Nil
readers = @readers.get { Deque(Fiber).new }
readers << Fiber.current
add_read_event(timeout)
Expand All @@ -136,11 +138,13 @@ module IO::Evented
event.add timeout
end

protected def wait_writable(timeout = @write_timeout)
# :nodoc:
def wait_writable(timeout = @write_timeout)
wait_writable(timeout: timeout) { |err| raise err }
end

protected def wait_writable(timeout = @write_timeout) : Nil
# :nodoc:
def wait_writable(timeout = @write_timeout) : Nil
writers = @writers.get { Deque(Fiber).new }
writers << Fiber.current
add_write_event(timeout)
Expand Down