-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Improve Colorize #7690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Improve Colorize #7690
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
b49ed16
Improve Colorize
2e6cdf4
Improve mode documentation
69d64e8
Make Colorize::Object#surround public again
702c6f2
Change Spec::COLORS to use the enum members
64cf180
Rename some variables and add documentation to surround
c22e57c
Fix specs
9432a4c
Fix specs
38ef634
Remove (*args)
f0cac30
Make RGB colorize's arguments more explicit
80180f0
Use color enum members in 2048.cr
e3b84b6
Add back Colorize::Object(T)#on and remove some documentation
ef19001
Remove unneeded parentheses and avoid capitalize in macro
743a6a9
Improve documentation
6425ad9
Fix Mode enum
c0f4405
Remove COLORS and MODES and use ColorANSI and Mode
8042ed4
More documentation
0f84ac8
Fix specs
ba56508
Remove the private attribute from two methods
d8ce0ce
Minor documentation improvements
d8d271b
Merge branch 'master' into patch-29
a9fda36
Add a missing comma
95569e2
Remove bright
c81322c
Don't generate all and none methods
94fc12e
Add bright back but deprecate it
fedd9d3
Commit Sija's suggestion
073e2d7
Remove useless `u8`s, fix the warning message and improve docs
830d994
Improve an example
0f2470b
Merge branch 'master' into patch-29
3c453bf
Remove on_tty_only!
16aa6fb
Merge branch 'master' into patch-29
9f19d98
Re-add on_tty_only!
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.